-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trade Republic German language parser #310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution, good to hear you think it is a cool project. Will have a look at it as soon as I'm able 😇 |
@mbks , for an initial version it looks fine. Let's merge it and i'll have a crack at the sell and dividends eventually 😄 For the sells and dividends, could you create an issue so we do not lose track 👼 |
VibeNL
approved these changes
Nov 11, 2024
@mbks It has been merged, and thank you for contributing 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you for the cool project.
I've attempted to add a parser for Trade Republic documents that works for German users. For buy orders it works fine for me (see the respective test cases), but for sell orders and dividends I faced some issues as sell does not seem to be implemented in the common parser yet and dividends are strangely structured in the German TR. I've added the (anonymized) files and commented test cases for these in the unit tests, so please have a look :)
I personally would be fine with only having buy order imports for now.
Thanks