Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade Republic German language parser #310

Merged
merged 10 commits into from
Nov 11, 2024
Merged

Conversation

mbks
Copy link
Contributor

@mbks mbks commented Nov 10, 2024

Hi!

Thank you for the cool project.
I've attempted to add a parser for Trade Republic documents that works for German users. For buy orders it works fine for me (see the respective test cases), but for sell orders and dividends I faced some issues as sell does not seem to be implemented in the common parser yet and dividends are strangely structured in the German TR. I've added the (anonymized) files and commented test cases for these in the unit tests, so please have a look :)
I personally would be fine with only having buy order imports for now.

Thanks

@VibeNL
Copy link
Owner

VibeNL commented Nov 10, 2024

Thank you for your contribution, good to hear you think it is a cool project.

Will have a look at it as soon as I'm able 😇

@VibeNL VibeNL added the enhancement New feature or request label Nov 10, 2024
@VibeNL
Copy link
Owner

VibeNL commented Nov 11, 2024

@mbks , for an initial version it looks fine. Let's merge it and i'll have a crack at the sell and dividends eventually 😄

For the sells and dividends, could you create an issue so we do not lose track 👼

@mbks mbks marked this pull request as ready for review November 11, 2024 17:05
@mbks
Copy link
Contributor Author

mbks commented Nov 11, 2024

Cool, thanks for having a look 😃
I've created two issues for the mentioned problems: #314 and #315
I will have another look at those as well when I have the time 😁

@VibeNL VibeNL enabled auto-merge (squash) November 11, 2024 17:38
@VibeNL VibeNL disabled auto-merge November 11, 2024 17:38
@VibeNL VibeNL merged commit d150200 into VibeNL:master Nov 11, 2024
1 check passed
@VibeNL
Copy link
Owner

VibeNL commented Nov 11, 2024

@mbks It has been merged, and thank you for contributing 😄

@mbks mbks deleted the trade_republic_german branch November 11, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants