BUG: TypeError in xmp._converter_date (py-pdf#813)

Fix: Convert decimal to int before passing it to datetime Closes py-pdf#774
VictorCarlquist · Apr 29, 2022 · 4f448b7 · 4f448b7
1 parent 68d424a
commit 4f448b7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/PyPDF2/xmp.py b/PyPDF2/xmp.py
@@ -107,6 +107,10 @@ def _converter_date(value):
         second = decimal.Decimal(m.group("second") or "0")
         seconds = second.to_integral(decimal.ROUND_FLOOR)
         milliseconds = (second - seconds) * 1000000
+
+        seconds = int(seconds)
+        milliseconds = int(milliseconds)
+
         tzd = m.group("tzd") or "Z"
         dt = datetime.datetime(year, month, day, hour, minute, seconds, milliseconds)
         if tzd != "Z":

diff --git a/Tests/test_xmp.py b/Tests/test_xmp.py
@@ -42,3 +42,9 @@ def get_all_tiff(xmp):
             contents.append(content.data)
         data[tag.tagName] = contents
     return data
+
+
+def test_regression_issue774():
+    cls = PyPDF2.xmp.XmpInformation
+    date = cls._converter_date("2021-04-28T12:23:34.123Z")
+    assert date.year == 2021