Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added configmap template #1735

Merged
merged 1 commit into from
Nov 12, 2024
Merged

added configmap template #1735

merged 1 commit into from
Nov 12, 2024

Conversation

AndrewChubatiuk
Copy link
Collaborator

fixes #1734

@github-actions github-actions bot added agent vmagent helm chart related issue alert vmalert helm chart related issue labels Nov 11, 2024
f41gh7
f41gh7 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewChubatiuk AndrewChubatiuk merged commit 04b68e1 into master Nov 12, 2024
14 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the configmap-template branch November 12, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@zekker6 zekker6 Awaiting requested review from zekker6 zekker6 is a code owner

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

Assignees
No one assigned
Labels
agent vmagent helm chart related issue alert vmalert helm chart related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Alertmanager deployment does not respect alertmanager.configMap value
2 participants
@AndrewChubatiuk @f41gh7