Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-stack: fix ingress API check to be compatible with ArgoCD #437

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

zekker6
Copy link
Contributor

@zekker6 zekker6 commented Dec 29, 2022

ArgoCD checks were not working due to argoproj/argo-cd#7291

This PR makes checks on per-API basis instead of resources ones.

Fixes #435

@github-actions github-actions bot added the k8s-stack k8s-stack helm chart related issue label Dec 29, 2022
Copy link
Contributor

@k1rk k1rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit d79e7a4 into master Dec 29, 2022
@f41gh7
Copy link
Collaborator

f41gh7 commented Dec 29, 2022

Thanks!

@f41gh7 f41gh7 deleted the fix/ingress-argocd-compatibility branch December 29, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k8s-stack k8s-stack helm chart related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s-stack: Wrong determining "kind: ingress" in k8s version > 1.22
3 participants