Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed docker caching in CI #1008

Merged
merged 3 commits into from
Jul 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ ARG TARGETARCH

WORKDIR /workspace
# Copy the Go Modules manifests
COPY go.mod go.mod
COPY go.sum go.sum
COPY go.* .
COPY api/go.* api/
# cache deps before building and copying source so that we don't need to re-download as much
# and so that source changes don't invalidate our downloaded layer
RUN go mod download
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ docker-buildx: ## Build and push docker image for the manager for cross-platform
--push \
--platform=$(PLATFORMS) \
--build-arg REPO=$(REPO) \
$(DOCKER_BUILD_ARGS) \
${DOCKER_BUILD_ARGS} \
--tag $(REGISTRY)/$(ORG)/$(REPO):$(TAG) \
--tag $(REGISTRY)/$(ORG)/$(REPO):$(BUILDINFO_TAG) \
-f Dockerfile.cross .
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ require (
github.com/VictoriaMetrics/VictoriaMetrics v1.101.0
github.com/VictoriaMetrics/metrics v1.34.0
github.com/VictoriaMetrics/metricsql v0.75.1
github.com/VictoriaMetrics/operator/api v0.0.0-20230626142506-8950675e8bb1
github.com/VictoriaMetrics/operator/api v0.0.0-20240628093553-60c6469c68af
github.com/fsnotify/fsnotify v1.7.0
github.com/ghodss/yaml v1.0.1-0.20190212211648-25d852aebe32
github.com/go-logr/logr v1.4.2
Expand Down