vmsingle: add status field #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f41gh7
requested changes
Jun 21, 2023
controllers/vmsingle_controller.go
Outdated
| return result, fmt.Errorf("failed to get deployment for vmsingle %s: %w", req.NamespacedName, err) | ||
| } | ||
|
|
||
| instance.Status.ReadyReplicas = currentDeploy.Status.ReadyReplicas |
There was a problem hiding this comment.
I think, we could skip Replicas fields changing, VMSingle always has only 1 replica.
There was a problem hiding this comment.
Oh, I stored ready pod replicas of deployment here to see if single is operational.
There was a problem hiding this comment.
Notice this note "if you need more - use vm cluster" until now :)
Fixed, not adding ReadyReplicas fields and keep rest replicas untouched for backward compatibility.
Haleygo
force-pushed
the
polish-vmsingle-status
branch
2 times, most recently
from
f0318f8
to
357764d
Compare
Haleygo
force-pushed
the
polish-vmsingle-status
branch
from
357764d
to
5b6c1f2
Compare
|
Thanks for contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#670
Status flow:
changes detected -> status expanding
CreateOrUpdateVMSingle returned an error -> status failed with reason.
CreateOrUpdateVMSingle and other functions returned no error -> status operational and update lastAppliedSpec.