Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor fixes #907

Merged
merged 3 commits into from
Mar 26, 2024
Merged

chore: minor fixes #907

merged 3 commits into from
Mar 26, 2024

Conversation

Haleygo
Copy link
Contributor

@Haleygo Haleygo commented Mar 22, 2024 •
edited
Loading

  1. follow up a54efbc, fix type struct field tags
  2. remove unnecessary pod permission for operator, see suggestion: remove pods * permissions for vmagent controller  #902
  3. remove fields VMClusterSpec.VMInsert.Name, VMClusterSpec.VMStorage.Name, VMClusterSpec.VMSelect.Name, they're marked as deprecated since v0.21.0 in 141c823.

@Haleygo
chore: minor fixes
388f3ce 
1. follow up a54efbc, fix type struct field tags
2. remove unnecessary pod permission for operator, see #902
@Haleygo Haleygo requested a review from f41gh7 March 22, 2024 04:14
@Haleygo Haleygo requested a review from Amper as a code owner March 22, 2024 04:14
f41gh7
f41gh7 reviewed Mar 22, 2024
View reviewed changes
config/rbac/role.yaml Outdated Show resolved Hide resolved
f41gh7
f41gh7 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@f41gh7 f41gh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@f41gh7 f41gh7 merged commit ac29c88 into master Mar 26, 2024
2 checks passed
@f41gh7 f41gh7 deleted the fix-minor-stuff branch March 26, 2024 15:23
@f41gh7
Copy link
Collaborator

f41gh7 commented Mar 26, 2024

Thanks for contribution!

@Haleygo Haleygo mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f41gh7 f41gh7 f41gh7 approved these changes

@Amper Amper Awaiting requested review from Amper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Haleygo @f41gh7