Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerts in Grafana with datasource VictoriaLogs #98

Closed
jackmachine3d opened this issue Oct 30, 2024 · 7 comments
Closed

Alerts in Grafana with datasource VictoriaLogs #98

jackmachine3d opened this issue Oct 30, 2024 · 7 comments
Assignees
@Loori-R
Labels
enhancement New feature or request

Comments

@jackmachine3d
Copy link

I used the latest version of the plugin for datasource Victorialand v0.6.1. It works fine. However, I noticed that I can't create alerts based on this datasource. The plugin itself says "Not supported". I would like to know if the ability to use VictroriaLogs as a datasource for notification via Grafana will be added?
image
@hagen1778
Copy link
Contributor

@Loori-R do you know if Grafana expects only plugins with certain type to be supported in Alerting mode?

@hagen1778 hagen1778 added the question Further information is requested label Oct 30, 2024
@Loori-R
Copy link
Contributor

Loori-R commented Oct 30, 2024

Initially, this alerting support was disabled because certain APIs required for alerts were not yet implemented in VictoriaLogs. I believe we now have the necessary APIs to develop this functionality. I’ll add the 'enhancement' label to this issue.

@Loori-R Loori-R added enhancement New feature or request and removed question Further information is requested labels Oct 30, 2024
@Loori-R Loori-R self-assigned this Oct 30, 2024
@jackmachine3d
Copy link
Author

Thanks for the quick reply. @Loori-R how long will it take to add this func?

@Loori-R
Copy link
Contributor

Loori-R commented Oct 31, 2024

@jackmachine3d, Not ready to provide exact timelines yet. Tentatively, we plan to implement it in November.

@hagen1778
Copy link
Contributor

Initially, this alerting support was disabled because certain APIs required for alerts were not yet implemented in VictoriaLogs. I believe we now have the necessary APIs to develop this functionality. I’ll add the 'enhancement' label to this issue.

I'd like to clarify that this enhancement will allow creating and managing alerting rules on the Grafana side.
It won't allow fetching rules configured via external ruler (like vmalert) similarly to VictoriaMetrics/victoriametrics-datasource#59.

Loori-R added a commit that referenced this issue Dec 3, 2024
@Loori-R
docs: update changelog for #98 and #111
fe50d9d
@Loori-R Loori-R mentioned this issue Dec 3, 2024
Merged
dmitryk-dk added a commit that referenced this issue Dec 4, 2024
@Loori-R @dmitryk-dk
add support for alerting and toggle between request types (#130)
016423c 
* add support alerting

* update query type usage

* cleanup

* cleanup

* docs: update changelog for #98 and #111

* feat: add options for legend template, max lines, and step

* fix indentation in code

---------

Co-authored-by: dmitryk-dk <kozlovdmitriyy@gmail.com>
@dmitryk-dk
Copy link
Contributor

Hi @jackmachine3d ! The feature was added in the new plugin release. Close this issue as resolved. Feel free to reopen the issue if you find any problems.

@jackmachine3d
Copy link
Author

Hi @dmitryk-dk thanks for the work done. You're the best guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Loori-R Loori-R

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hagen1778 @dmitryk-dk @Loori-R @jackmachine3d