Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass export file name #39

Open
eggzilla opened this issue Feb 21, 2018 · 6 comments
Open

Pass export file name #39

eggzilla opened this issue Feb 21, 2018 · 6 comments

Comments

@pkerpedjiev
Copy link
Collaborator

Do you want that to essentially become an API so that you can automatically get an SVG from visiting that URL or are you just saying that the passed in export_name should be the default filename that is used when saving an SVG?

@eggzilla
Copy link
Author

eggzilla commented Feb 23, 2018

Hey, thanks for the fast reply! I mean the second variant.

@pkerpedjiev
Copy link
Collaborator

Cool. That's certainly the easier option. Unfortunately, I'm not sure when I'll have time to do this but if you want to try yourself, the code for saving SVGs is here:

https://github.com/pkerpedjiev/forna/blob/c5a911f88162fa6c9a8d126b13ce7e2da89c1edb/htdocs/js/interface.js#L1278

Url parameters are in the queries variable in interface.js:

https://github.com/pkerpedjiev/forna/blob/c5a911f88162fa6c9a8d126b13ce7e2da89c1edb/htdocs/js/interface.js#L477

It should be relatively simple to combine the two to achieve what you want. If you want to implement this, I'm happy to merge a PR.

@eggzilla
Copy link
Author

Thanks! I will give it a try :-)

@j-4 j-4 added the enhancement label Jun 6, 2019
@j-4
Copy link
Collaborator

j-4 commented Jun 6, 2019

Hi egg, have you succeeded or do you need help here?

@eggzilla
Copy link
Author

eggzilla commented Jun 6, 2019

Unknown, I will investigate if I implemented a workaround. Thanks for asking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants