Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes problems with ReplRestart #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frere-jacques
Copy link

If one opens a REPL and then Restarts a REPL, one gets errors about wrong buffer ids.

The reason is that core.repl_restart deletes the old buffer. But the default of close_window_on_exit, will try to delete it too.

Also if one calls IronRestart from a code buffer, changes are done to meta, but new_meta is returned.

I made a commit that fixes this, by not altering meta, but altering new_meta.
Also it will be checked in the on exit option, whether the buffer still exist.

I will create a merge request.

I also observed that many functions will differ strongly whether the cursor is on code buffer or repl buffer. One could change that if the get_ft would check on empty file type, if the buffer is the buffer of a repl and then use the ft from store.
I checked that, but I am unsure whether this could have some side effects.

See #387 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant