fix: drop useless/harmful nvim_set_hl_ns #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The highlight absolutely does not need to be in the same namespace as the extmarks, and we definitely do not need to globally change the highlight namespace, as that might interfere with other plugins or the user's config or whatever. And it happens to break background colors in floats (such as LSP hover, diagnostic detail, completion help, etc.) due to a bug in neovim: neovim/neovim#30262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The highlight absolutely does not need to be in the same namespace as the extmarks, and we definitely do not need to globally change the highlight namespace, as that might interfere with other plugins or the user's config or whatever.
And it happens to break background colors in floats (such as LSP hover, diagnostic detail, completion help, etc.) due to a bug in neovim: neovim/neovim#30262