Skip to content

Commit

Permalink
Apply feedback and update docstring of MutableMapping.update
Browse files Browse the repository at this point in the history
  • Loading branch information
Viicos committed Oct 11, 2024
1 parent 2d72b2e commit 06f9ddb
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 14 deletions.
22 changes: 11 additions & 11 deletions Doc/library/stdtypes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4506,13 +4506,13 @@ can be used interchangeably to index the same dictionary entry.

If no positional argument is given, an empty dictionary is created.
If a positional argument is given and it defines a ``keys()`` method, a
dictionary is created by calling ``__getitem__`` on the argument with each
returned key from the method. Otherwise, the positional argument must be an
dictionary is created by calling :meth:`~object.__getitem__` on the argument with
each returned key from the method. Otherwise, the positional argument must be an
:term:`iterable` object. Each item in the iterable must itself be an iterable
with exactly two objects. The first object of each item becomes a key in the new
dictionary, and the second object the corresponding value. If a key occurs more
than once, the last value for that key becomes the corresponding value in the new
dictionary.
with exactly two objects. The first element of each item becomes a key in the
new dictionary, and the second element the corresponding value. If a key occurs
more than once, the last value for that key becomes the corresponding value in
the new dictionary.

If keyword arguments are given, the keyword arguments and their values are
added to the dictionary created from the positional argument. If a key
Expand Down Expand Up @@ -4669,11 +4669,11 @@ can be used interchangeably to index the same dictionary entry.
Update the dictionary with the key/value pairs from *other*, overwriting
existing keys. Return ``None``.

:meth:`update` accepts either another object with a ``keys()`` method
(in which case ``__getitem__`` is called with every key returned from the method).
or an iterable of key/value pairs (as tuples or other iterables of length two).
If keyword arguments are specified, the dictionary is then updated with those
key/value pairs: ``d.update(red=1, blue=2)``.
:meth:`update` accepts either another object with a ``keys()`` method (in
which case :meth:`~object.__getitem__` is called with every key returned from
the method). or an iterable of key/value pairs (as tuples or other iterables
of length two). If keyword arguments are specified, the dictionary is then
updated with those key/value pairs: ``d.update(red=1, blue=2)``.

.. method:: values()

Expand Down
2 changes: 1 addition & 1 deletion Lib/_collections_abc.py
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@ def clear(self):

def update(self, other=(), /, **kwds):
''' D.update([E, ]**F) -> None. Update D from mapping/iterable E and F.
If E present and has a .keys() method, does: for k in E: D[k] = E[k]
If E present and has a .keys() method, does: for k in E.keys(): D[k] = E[k]
If E present and lacks .keys() method, does: for (k, v) in E: D[k] = v
In either case, this is followed by: for k, v in F.items(): D[k] = v
'''
Expand Down

This file was deleted.

0 comments on commit 06f9ddb

Please sign in to comment.