Add pyright to CI

.github/workflows/tests.yml

@@ -3,6 +3,22 @@ name: tests
 on: [push]
 
 jobs:
+  typecheck:
+    name: Run typechecking with pyright
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Set up Python 3.12
+        uses: actions/setup-python@v5
+        with:
+          python-version: '3.12'
+      - name: Install dependencies
+        run: |
+          pip install uv
+          uv pip sync --system requirements/requirements.txt requirements/requirements-test.txt
+      - name: Run pyright
+        run: pyright
+
   test:
     name: Run tests with pytest
     runs-on: ubuntu-latest

pyproject.toml

@@ -28,7 +28,7 @@ classifiers = [
 license = {file = "LICENSE"}
 requires-python = ">=3.8"
 dependencies = [
-    "typing-extensions>=4.0.1; python_version < '3.10'",
+    "typing-extensions>=4.10.0; python_version < '3.13'",
 ]
 
 [tool.setuptools]

requirements/requirements-dev.in

@@ -1,2 +1,3 @@
 -c requirements.txt
+pyright
 ruff

requirements/requirements-dev.txt

@@ -4,5 +4,12 @@
 #
 #    pip-compile requirements/requirements-dev.in
 #
+nodeenv==1.8.0
+    # via pyright
+pyright==1.1.360
+    # via -r requirements/requirements-dev.in
 ruff==0.3.2
     # via -r requirements/requirements-dev.in
+
+# The following packages are considered to be unsafe in a requirements file:
+# setuptools

requirements/requirements-test.in

@@ -1,4 +1,5 @@
 -c requirements.txt
+pyright
 pytest
 tomli
 tox

requirements/requirements-test.txt

@@ -18,6 +18,8 @@ filelock==3.13.1
     #   virtualenv
 iniconfig==2.0.0
     # via pytest
+nodeenv==1.8.0
+    # via pyright
 packaging==24.0
     # via
     #   pyproject-api
@@ -33,6 +35,8 @@ pluggy==1.4.0
     #   tox
 pyproject-api==1.6.1
     # via tox
+pyright==1.1.360
+    # via -r requirements/requirements-test.in
 pytest==8.1.1
     # via -r requirements/requirements-test.in
 tomli==2.0.1
@@ -45,3 +49,6 @@ tox-gh-actions==3.2.0
     # via -r requirements/requirements-test.in
 virtualenv==20.25.1
     # via tox
+
+# The following packages are considered to be unsafe in a requirements file:
+# setuptools

src/jsonlogic/core.py

@@ -81,7 +81,7 @@ class JSONLogicExpression:
     expression: JSONLogicPrimitive | NormalizedExpression
 
     @classmethod
-    def from_json(cls, json: JSON) -> Self:  # TODO disallow list?
+    def from_json(cls, json: JSON) -> Self:  # TODO disallow list? TODO fix type errors
         """Build a JSON Logic expression from JSON data.
 
         Operator arguments are recursively normalized to a :class:`list`::
@@ -90,15 +90,15 @@ def from_json(cls, json: JSON) -> Self:  # TODO disallow list?
             assert expr.expression == {"var": ["varname"]}
         """
         if not isinstance(json, dict):
-            return cls(expression=json)
+            return cls(expression=json)  # type: ignore
 
         operator, op_args = next(iter(json.items()))
         if not isinstance(op_args, list):
             op_args = [op_args]
 
         sub_expressions = [cls.from_json(op_arg) for op_arg in op_args]
 
-        return cls({operator: sub_expressions})
+        return cls({operator: sub_expressions})  # type: ignore
 
     def as_operator_tree(self, operator_registry: OperatorRegistry) -> JSONLogicPrimitive | Operator:
         """Return a recursive tree of operators, using the provided registry as a reference.