hypothetically fix all failing tests

VikeLabs · Mar 8, 2024 · 1ae1706 · 1ae1706
1 parent 5be2f25
commit 1ae1706
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 12 deletions.
diff --git a/functions/src/constants.ts b/functions/src/constants.ts
@@ -12,7 +12,8 @@ export type Term =
   | '202301'
   | '202305'
   | '202309'
-  | '202401';
+  | '202401'
+  | '202405';
 
 // make const array of terms from above
 export const terms: Term[] = [
@@ -29,6 +30,7 @@ export const terms: Term[] = [
   '202305',
   '202309',
   '202401',
+  '202405',
 ];
 
 // add some code?

diff --git a/src/common/header/components/__tests__/TermSelect.test.tsx b/src/common/header/components/__tests__/TermSelect.test.tsx
@@ -30,23 +30,23 @@ describe('TermSelect', () => {
     render(<TermSelect />);
     const termSelect = screen.getByRole('combobox') as HTMLSelectElement;
 
-    expect(termSelect.value).toStrictEqual('202305');
+    expect(termSelect.value).toStrictEqual('202309');
   });
 
   it('should navigate to the selected term', () => {
     render(<TermSelect />);
     const termSelect = screen.getByRole('combobox') as HTMLSelectElement;
 
-    const summerOption = screen.getAllByRole('option')[0];
-    userEvent.selectOptions(termSelect, summerOption);
-    expect(mockNavigate).toBeCalledWith('/calendar/202305');
-
-    const fallOption = screen.getAllByRole('option')[1];
+    const fallOption = screen.getAllByRole('option')[0];
     userEvent.selectOptions(termSelect, fallOption);
     expect(mockNavigate).toBeCalledWith('/calendar/202309');
 
-    const springOption = screen.getAllByRole('option')[2];
+    const springOption = screen.getAllByRole('option')[1];
     userEvent.selectOptions(termSelect, springOption);
     expect(mockNavigate).toBeCalledWith('/calendar/202401');
+
+    const summerOption = screen.getAllByRole('option')[2];
+    userEvent.selectOptions(termSelect, summerOption);
+    expect(mockNavigate).toBeCalledWith('/calendar/202405');
   });
 });
diff --git a/src/lib/fetchers.tsx b/src/lib/fetchers.tsx
@@ -22,7 +22,8 @@ export type Term =
   | '202301'
   | '202305'
   | '202309'
-  | '202401';
+  | '202401'
+  | '202405';
 
 export interface NestedPreCoRequisites {
   reqList?: (NestedPreCoRequisites | KualiCourse | string)[];

diff --git a/src/pages/calendar/components/__tests__/Requisites.test.tsx b/src/pages/calendar/components/__tests__/Requisites.test.tsx
@@ -22,13 +22,13 @@ const reqNested = {
 
 describe('DisplayRequirement', () => {
   it('should render the string requirement', () => {
-    mockUseSessionStorage.mockReturnValue(['202305', mockSetTerm]);
+    mockUseSessionStorage.mockReturnValue(['202309', mockSetTerm]);
     render(DisplayRequirement(reqString, 1));
     expect(screen.getByTitle('Requisite')).toHaveTextContent('with a minimum GPA of 3.0 over all courses');
   });
 
   it('should render the course requirement', () => {
-    mockUseSessionStorage.mockReturnValue(['202305', mockSetTerm]);
+    mockUseSessionStorage.mockReturnValue(['202309', mockSetTerm]);
     render(
       DisplayRequirement(
         {
@@ -42,7 +42,7 @@ describe('DisplayRequirement', () => {
   });
 
   it('should render the nested requirement', () => {
-    mockUseSessionStorage.mockReturnValue(['202305', mockSetTerm]);
+    mockUseSessionStorage.mockReturnValue(['202309', mockSetTerm]);
     render(DisplayRequirement(reqNested, 1));
     expect(screen.getByTitle(`${reqNested.reqList[0].subject} ${reqNested.reqList[0].code}`)).toHaveTextContent(
       'PHYS 111'