Fix/smart filename fallback #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 20, 2025 09:54
- Try meaningful filenames first (using attributes.title/name) - Detect when jsrmx fails to create files due to invalid filename characters - Automatically fall back to sequential numbering when needed - Resolves 'No such file or directory' errors for objects with special chars like [, ], & - Maintains user-friendly filenames when possible while ensuring reliability Fixes issue where large dashboards with special characters in titles (e.g., '[Elasticsearch] Dashboard & View') would fail to unbundle properly.
- Change from all-or-nothing fallback to per-object processing - Preserve meaningful names for objects with valid characters - Only apply sequential numbering to specific failed objects - Extract failed objects to temporary file and process separately Before: If any object had invalid filename chars, ALL objects got sequential names After: Only objects with invalid chars get sequential names (e.g., & * : , parentheses) Results: ~82% of objects retain meaningful filenames while problematic ones get reliable sequential numbering (object-000X.type.json) Improves user experience by maximizing filename readability while maintaining reliability for objects with filesystem-incompatible characters.
|
Hmm... this is a valid concern, but I'm not sure I agree with the approach. If it is possible to create dashboard titles with characters that are invalid for filenames, I think this is better fixed in |
|
Created VimCommando/jsrmx#9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.