Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnail visibility options #175

Closed
wants to merge 1 commit into from
Closed

Add thumbnail visibility options #175

wants to merge 1 commit into from

Conversation

hacktivateit
Copy link
Contributor

refs #160

Add the ability to show/hide the thumbnail image inside post and/or the homepage, both options default to true

@jorgepiloto
Copy link

Thank you for opening this @Betmaster! I am interested in this particular feature. What do you think about the status of this, @Vimux? Is it ready to be merged? It looks like all tests passed 👍🏽

@Vimux
Copy link
Owner

Vimux commented Aug 16, 2021

Hi @jorgepiloto,

The current implementation is not ready enough:

Important:

  1. Params:
    1. Unclear naming:show_thumb_in_home not only for the home page but for all list-like pages
    2. Hard to remember both params (without README). Take a look at any other theme-defined front-matter parameters.
    3. Three underscores are overkill.
    4. It might be worth considering alternatives to how to add this. I mean not only the param name but also the structure itself (map?).
  2. Complex thumbnail (adding new params increases complexity) requires separation into a separate part. Better to do separation first, in an isolated PR, but with this PR and possibly other changes (Add Page Bundles and Image Processing support #57???) in mind, other than complete remade/find hacks for this repeatedly in the future.

Minor:

  1. Tabs/spaces mixing
  2. EOL changes

@jorgepiloto
Copy link

Thanks @Vimux for listing the different suggestions and requested changes. Hopefully @Betmaster or another user may apply them. I wish my knowledge of Hugo was deeper so I could help you with some of the work in this project. Really like this theme! ❤️

Vimux added a commit that referenced this pull request Sep 9, 2021
Initial revision of thumbnail visibility control allows you to turn off
thumbnails for list-like or single pages globally and per page.

Fixes #160
Closes #175
@Vimux Vimux closed this in #274 Sep 9, 2021
@Vimux
Copy link
Owner

Vimux commented Sep 9, 2021

@jorgepiloto,

Not sure if this is still relevant for you, but it should work now.

@jorgepiloto
Copy link

jorgepiloto commented Sep 9, 2021

Thanks for implementing this @Vimux! 🎉

I took a view to the pull request and really like the way this can be configured, either globally or for a particular post. Working as expected locally 👍🏽

gmtborges pushed a commit to gmtborges/Mainroad that referenced this pull request Jan 22, 2023
Initial revision of thumbnail visibility control allows you to turn off
thumbnails for list-like or single pages globally and per page.

Fixes Vimux#160
Closes Vimux#175
nikolaswise pushed a commit to nikolaswise/Mainroad that referenced this pull request Dec 20, 2024
Initial revision of thumbnail visibility control allows you to turn off
thumbnails for list-like or single pages globally and per page.

Fixes Vimux#160
Closes Vimux#175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants