fix(layout): performances optimization #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is awesome. Would love to see it merged. |
vbylen
approved these changes
May 23, 2022
|
Seems like a great change. Would also vote to merge this and get a new version published! |
|
Voted. |
|
@VincentCATILLON can we get this merged? |
|
I think you should create a new repository, Vincent seems to have abandoned the project unfortunately |
chrisedington
pushed a commit
to shopstarco/react-native-confetti-cannon
that referenced
this pull request
Sep 30, 2022
|
Hi @uragirii @alexcastillo @corbt @chrisedington @jonathanroze , Sorry about the delay. I'll take a look and post a review to be able to publish it as soon as possible 🙏 Thanks in advance for your contribution |
VincentCATILLON
changed the title
mirzabiz
approved these changes
Dec 13, 2022
felipecsl
added a commit
to Alza-app/react-native-confetti-cannon-fork
that referenced
this pull request
Mar 15, 2023
felipecsl
added a commit
to Alza-app/react-native-confetti-cannon-fork
that referenced
this pull request
Mar 15, 2023
felipecsl
added a commit
to Alza-app/react-native-confetti-cannon-fork
that referenced
this pull request
Mar 16, 2023
* Apply changes from VincentCATILLON#53 * move from flow to tsc + fix types * update deps * do not push build directory * reapply changes from VincentCATILLON#53 * revert package name change
pTinosq
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the conditional rendering of the children according to animation. When the animation is running, the View nodes are mounted and they are unmounted after the animation finishes. I've also implemented 2 tests to test this behavior. This should provide a performance boost in the case of low-end devices. Unnecessary children are not rendered.
Related issues