You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Argument of type '{ maxBatchSize: number; }' is not assignable to parameter of type 'GraphOptions'.
Property 'joinOperation' is missing in type '{ maxBatchSize: number; }' but required in type 'GraphOptions'.ts(2345)
The text was updated successfully, but these errors were encountered:
Isn't also aliases incorrectly typed? We are having issues as well having the joinOperation as mandatory, but a bigger problem for us is the aliases which asks for a string[]. Based on the docs, it should be an object right?
Shouldn't it be: aliases?: { [key: string]: string }?
By the way, thanks for this amazing library!
Freakazo
added a commit
to Freakazo/objection.js
that referenced
this issue
Feb 2, 2021
GraphOptions.joinOperation is typed as required here:
objection.js/typings/objection/index.d.ts
Lines 752 to 758 in 412bb77
which is not correct because it defaults to
leftJoin
.In particular, this leads to Typescript error in innocent uses like:
result:
The text was updated successfully, but these errors were encountered: