Support $beforeUpdate() mutations in upsertGraph()

[lehni]

Closes #2233

[falkenhawk]

I am a bit afraid of this change - could you tell more about why the execution order of hooks had to be changed to fix the issue, please?

[lehni]

I need runBefore to run after onBefore2() in UpdateOperation which triggers the execution of $beforeUpdate(). I tried it and it didn't break any tests. I looked at afterExecute(), and it has the same sequence.

In the end, this is just a proof of concept more than anything for now. I do think that the behavior it produces is more according to what I would expect though.

function afterExecute(builder, result) {
  let promise = Promise.resolve(result);

  promise = chainOperationHooks(promise, builder, 'onAfter1');
  promise = chainOperationHooks(promise, builder, 'onAfter2');

  promise = chainHooks(promise, builder, builder.context().runAfter);
  promise = chainHooks(promise, builder, builder.internalContext().runAfter);

  promise = chainOperationHooks(promise, builder, 'onAfter3');

  return promise;
}

[umutuzgur]

Hey @lehni 👋 Are you planning to merge and release this soon? We are looking forward to update finally to the latest objection version 😬

[falkenhawk]

I've just run our test suites on a project which uses upsertGraph a lot, with the changes from this PR applied and nothing broke. I also didn't observe any performance degradation, so it looks good 👍

[lehni]

Good news! I still need to write a test for this, but will merge it soon.

[lehni]

I have improved the code to detect the presence of beforeUpdate hooks, and revert to the old behavior of dropping out earlier if there are none. This is to avoid any potential performance implications or other potential changes in behavior.