Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepix3 updates #60

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Timepix3 updates #60

merged 5 commits into from
Oct 29, 2024

Conversation

magruber
Copy link
Contributor

  • Changes the event building in the raw_data_manipulation from ToA to ToA combined
  • Adds the fToA of Timepix3 to the output of raw_data_manipulation and reconstruction

@Vindaar
Copy link
Owner

Vindaar commented Oct 28, 2024

Both bugs (zeroes in ToA_combined output) and too large values in fTOA were related.

The first one was my bug. In ToA_combined I accidentally wrote the data as uint16 instead of uint64. This lead to each individual element being interpreted as 4 uint16 values, of which most of the time 3 were zeroes (interpreting a 64 bit "bigint" as 4 uint16 limbs will have most limbs zero if the uint64 values are usually small).

For the fTOA you then copied my bug and wrote the fTOA values, which should be uint8 as uint16. That treated 2 values as a single one of much larger size (hence the thousands).

I force pushed to your branch, because I would have had to rebase. And to better test locally (to make sure things work on latest HEAD), I rebased locally.

@Vindaar Vindaar merged commit a1c19d4 into Vindaar:master Oct 29, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants