-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to define constraints to filter run periods #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the chip group attributes
This is required to keep the DAC information for Tpx3 among others
When using the database tool to add a run period, now includes parsing the constraints.
Requires the chip group as an argument to the relevant proc calls.
… runPeriod Still to be finished! Does not look up the run period just now.
Now has the commands: - add - calibrate instead of having everything under a single command. Allows for a cleaner interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to control how run periods are matched at a finer level. Instead of just relying on run numbers, one can now define constraints based on data stored in the HDF5 files.
In very short:
Read the README here:
https://github.com/Vindaar/TimepixAnalysis/tree/addConstraints/resources/ChipCalibrations/Tpx3_Test_Constraints
for detailed instructions.