Scale is now a ref object to avoid excessive stack usage
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scale previously was a huge stack waster. This caused the failures seen in: nim-lang/Nim#13206 The test =tests/tests.nim= previously required a stack of about 3600 kB to avoid a stack overflow. With the =Scale= being a =ref object= we get that down to 135 kB!
|
I have no idea why github pretends travis didn't perform a build of this. It certainly did and it passed. So merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale previously was a huge stack waster. This caused the failures
seen in:
nim-lang/Nim#13206
The test =tests/tests.nim= previously required a stack of about 3600
kB to avoid a stack overflow. With the =Scale= being a =ref object= we
get that down to 135 kB!
I simply checked the impact of making each used object a
ref objecton thetests.nimtest case.