Improve noargs message and add a help argument + detailed message #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaskarth
added
Priority: High
jaskarth
requested changes
Aug 7, 2022
| @@ -60,10 +62,119 @@ else if (args.length > x+1) { | |||
| } | |||
| args = params.toArray(new String[params.size()]); | |||
|
|
|||
| if (Arrays.stream(args).anyMatch(arg -> arg.equals("-h") || arg.equals("--help") || arg.equals("-help"))) { | |||
| String[] help = { | |||
There was a problem hiding this comment.
This array should be private static final, or the like
| @@ -60,10 +62,119 @@ else if (args.length > x+1) { | |||
| } | |||
| args = params.toArray(new String[params.size()]); | |||
|
|
|||
| if (Arrays.stream(args).anyMatch(arg -> arg.equals("-h") || arg.equals("--help") || arg.equals("-help"))) { | |||
There was a problem hiding this comment.
The content of this if body should be moved out to another method (or maybe even another class) because the main method is getting very long
Now only the help message is its own class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.