Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for generic types and discard any unexpected types #430

Open
wants to merge 3 commits into
base: develop/1.11.0
Choose a base branch
from

Conversation

sschr15
Copy link
Member

@sschr15 sschr15 commented Sep 14, 2024

Fixes #409 by adding checks and discarding any clearly bogus generics

Copy link

github-actions bot commented Sep 14, 2024

Test Results

   18 files  ±0     18 suites  ±0   1m 4s ⏱️ -1s
1 930 tests +1  1 929 ✅ +1  1 💤 ±0  0 ❌ ±0 
2 556 runs  +2  2 554 ✅ +2  2 💤 ±0  0 ❌ ±0 

Results for commit 1c14529. ± Comparison against base commit fd167c7.

♻️ This comment has been updated with latest results.

@SpaceWalkerRS
Copy link

How do these checks work when signatures depend on each other? For example, a field that initially has a valid signature, but its type class's signature does not pass the check and is modified/removed, which in turn then invalidates that field's signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants