feat: add setting to disable 'No changes...' popups (#676)

* Added setting to disable 'No changes...' popups

When notifications aren't disabled this new setting
will be displayed. Enabling this setting, will prevent
the "No changes to push" and "No changes to commit"
messages from displaying. This doesn't prevent
these notifcations from appearing in the status bar.

* Update src/main.ts

Co-authored-by: Vinzent <vinzentwitte@gmail.com>

* style: format

---------

Co-authored-by: Vinzent <vinzentwitte@gmail.com>
Co-authored-by: Vinzent <vinzent03@proton.me>

src/constants.ts

@@ -17,6 +17,7 @@ export const DEFAULT_SETTINGS: Omit<ObsidianGitSettings, "autoCommitMessage"> =
         disablePush: false,
         pullBeforePush: true,
         disablePopups: false,
+        disablePopupsForNoChanges: false,
         listChangedFilesInMessageBody: false,
         showStatusBar: true,
         updateSubmodules: false,

src/main.ts

@@ -1728,7 +1728,12 @@ I strongly recommend to use "Source mode" for viewing the conflicted files. For
         this.statusBar?.displayMessage(message.toLowerCase(), timeout);
 
         if (!this.settings.disablePopups) {
-            new Notice(message, 5 * 1000);
+            if (
+                !this.settings.disablePopupsForNoChanges ||
+                !message.startsWith("No changes")
+            ) {
+                new Notice(message, 5 * 1000);
+            }
         }
 
         console.log(`git obsidian message: ${message}`);

src/setting/settings.ts

@@ -470,10 +470,26 @@ export class ObsidianGitSettingsTab extends PluginSettingTab {
                     .setValue(plugin.settings.disablePopups)
                     .onChange((value) => {
                         plugin.settings.disablePopups = value;
+                        this.display();
                         plugin.saveSettings();
                     })
             );
 
+        if (!plugin.settings.disablePopups)
+            new Setting(containerEl)
+                .setName("Hide notifications for no changes")
+                .setDesc(
+                    "Don't show notifications when there are no changes to commit/push"
+                )
+                .addToggle((toggle) =>
+                    toggle
+                        .setValue(plugin.settings.disablePopupsForNoChanges)
+                        .onChange((value) => {
+                            plugin.settings.disablePopupsForNoChanges = value;
+                            plugin.saveSettings();
+                        })
+                );
+
         new Setting(containerEl)
             .setName("Show status bar")
             .setDesc(

src/types.ts

@@ -12,6 +12,7 @@ export interface ObsidianGitSettings {
     disablePush: boolean;
     pullBeforePush: boolean;
     disablePopups: boolean;
+    disablePopupsForNoChanges: boolean;
     listChangedFilesInMessageBody: boolean;
     showStatusBar: boolean;
     updateSubmodules: boolean;