Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Create backup command says No changes to commit when all changes are staged #253

Closed
NomarCub opened this issue Jul 1, 2022 · 2 comments
Closed

[Bug]: Create backup command says No changes to commit when all changes are staged #253

NomarCub opened this issue Jul 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@NomarCub
Copy link

NomarCub commented Jul 1, 2022

Describe the bug

Title says it all. If there are any non-staged changes, then all changes are backed up normally.

Relevant errors (if available)

No response

Steps to reproduce

  • init a repo
  • make changes and stage them all
  • execute the Create backup command

Expected Behavior

A backup is made when there are any changes, even if all are staged.

Addition context

No response

Operating system

Windows

Plugin version

1.26.1
@Vinzent03 Vinzent03 added the bug Something isn't working label Jul 10, 2022
@NomarCub
Copy link
Author

The fix didn't work. The fix commit looks wrong too, but easy to fix f71fdf5

Vinzent03 added a commit that referenced this issue Jul 17, 2022
@Vinzent03
fix: commit only staged files, again
ba35555 
#253
@Vinzent03
Copy link
Owner

Oh what a stupid mistake, haha. Should be really fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NomarCub @Vinzent03