Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update settings grammar #656

Merged
merged 3 commits into from
Jan 8, 2024
Merged

fix: update settings grammar #656

merged 3 commits into from
Jan 8, 2024

Conversation

PScoriae
Copy link
Contributor

@PScoriae PScoriae commented Dec 16, 2023 •
edited
Loading

What my changes do:

  • add formatMinutes function
    • use "minute" when autoSaveInterval is 1
    • else use "minutes"
    • Prevents the scenario phrase "1 minutes."
  • Improve grammar for autoBackupAfterFileChange plugin
    • turn message into multiline string for easier readability in code

I did think about omitting the interval value if it's set to 1 i.e.:

  • "Every minute."
  • "Every x minutes."

But I believe being more explicit with whatever interval value the user has set reinforces the idea that the application has registered their input.

@PScoriae PScoriae marked this pull request as draft December 16, 2023 04:08
@PScoriae
feat: add formatMinutes function
c9df533
@PScoriae
fix: update backup interval notice grammar
9267fee 
- use "minute" when autoSaveInterval is 1
- else use "minutes"
- uses the formatMinutes function
@PScoriae PScoriae marked this pull request as ready for review December 16, 2023 04:53
@PScoriae PScoriae changed the title fix: update backup interval notice grammar fix: update settings grammar Dec 16, 2023
antonkesy
antonkesy approved these changes Jan 7, 2024
View reviewed changes
Copy link

@antonkesy antonkesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vinzent03
Copy link
Owner

Thanks for your contribution!

@Vinzent03 Vinzent03 merged commit d9e8be1 into Vinzent03:master Jan 8, 2024
4 checks passed
@PScoriae PScoriae deleted the update-notice-grammar branch January 9, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonkesy antonkesy antonkesy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PScoriae @Vinzent03 @antonkesy