Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env var OBSIDIAN_GIT for scripting #71

Merged
merged 1 commit into from
May 2, 2021
Merged

feat: add env var OBSIDIAN_GIT for scripting #71

merged 1 commit into from
May 2, 2021

Conversation

zanets
Copy link
Contributor

@zanets zanets commented May 2, 2021

I have a pre-push hook that ask for user confirmation. Sadly it makes obsidian-git push failed by timeout since I cannot make tty input.

A simple solution is to add an environment variable when spawn git process, check it in the hook and bypass the confirmation.

I also think configurable push command will be cool, but it's too much for this case.

@denolehov
Copy link
Collaborator

lgtm, @Vinzent03 agree?

@Vinzent03
Copy link
Owner

So far I didn't work on other issues, because I didn't want to get merge conflicts with #66 , but I am already waiting a long time for the missing method from the Obsidian devs. I have no clue, when they will add that. I am okay with merging this. Will implement #70 and #68 hopefully this evening and will publish a release then.

@Vinzent03 Vinzent03 merged commit b9ab82a into Vinzent03:master May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants