feat(core/formatter): add slice, sort, and merge array modifiers #493
Conversation
WalkthroughExtends the modifier system by adding Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/core/src/formatters/base.ts (1)
754-768: Slice modifier implementation is correct.The logic correctly handles both
slice(start)andslice(start, end)patterns with appropriate fallback behaviour.Minor style inconsistency: Line 757 has
_mod.length -1whilst line 771 uses_mod.length - 1with proper spacing around the operator.Apply this diff for consistency:
- const args = _mod - .substring(6, _mod.length -1) - .split(',') - .map((arg) => parseInt(arg.trim(), 10)); + const args = _mod + .substring(6, _mod.length - 1) + .split(',') + .map((arg) => parseInt(arg.trim(), 10));
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/core/src/formatters/base.ts(5 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-14T16:46:18.507Z
Learnt from: DavidGracias
Repo: Viren070/AIOStreams PR: 375
File: packages/core/src/formatters/base.ts:0-0
Timestamp: 2025-09-14T16:46:18.507Z
Learning: In packages/core/src/formatters/base.ts, the modifier definitions intentionally include regex patterns (like "join('.*?')", "$.*?", "^.*?") that require pattern matching functionality. The buildModifierRegexPattern() method should not fully escape all regex metacharacters as this would break the intended regex matching behavior within modifier definitions.
Applied to files:
packages/core/src/formatters/base.ts
🔇 Additional comments (6)
packages/core/src/formatters/base.ts (6)
592-594: LGTM! Context parameter properly propagated.The addition of
parseValueas a parameter enables context-aware modifiers like merge to access other variables from the parse context.
636-637: LGTM! Return type appropriately extended.The extended return type
any[]allows array modifiers to preserve array types through chaining, which is essential for the new slice, sort, and merge functionality.
769-791: LGTM! Robust sort implementation with numeric awareness.The implementation correctly:
- Validates the direction parameter
- Uses spread operator to avoid mutation
- Provides numeric-aware sorting via
localeComparewithnumeric: trueoption- Handles both pure numeric and mixed-type arrays appropriately
797-820: LGTM! Merge implementation with sensible fallback.The implementation correctly:
- Validates the variable path format (requires
{...}wrapper)- Checks that the target property is an array before merging
- Gracefully falls back to the original array if the merge target is invalid
Note: The merge modifier doesn't support modifiers within the path (e.g.,
merge('{stream.audioChannels::slice(0, 2)}')), which is a reasonable design choice to maintain simplicity.
964-972: LGTM! Type signature appropriately broadened.The updated signature
any[]enables the sort modifier to handle arrays containing numbers, strings, or mixed types whilst maintaining numeric-aware comparison for consistency with the new parametrised sort modifier.
1025-1030: LGTM! Regex patterns correctly defined.The hardcoded modifier patterns appropriately:
- Match both single-argument
slice(n)and two-argumentslice(n, m)forms with flexible whitespace- Cover both ascending and descending sort directions
- Support both single and double quote delimiters for merge
1 participant
Adds three new modifiers for arrays
Slice modifier
Usage: ::slice(start, end) or ::slice(start)
Example:
{stream.visualTags::slice(0, 2)}Input:
10bit, HDR, DV, 3D, IMAXOutput:
10bit, HDRSort modifier
Usage: ::sort(asc) or ::sort(desc)
Example (alphabetical):
{stream.audioTags::sort(asc)}Input:
Atmos, DTS-HD MA, TrueHD, OPUS, AACOutput:
AAC, Atmos, DTS-HD MA, OPUS, TrueHDExample (numerical):
{stream.seasons::sort(desc)}Input:
1, 2, 3, 4, 5, 6, 7, 8Output:
8, 7, 6, 5, 4, 3, 2, 1Note: Combined alphabetical/numerical sorting is possible
Merge modifier
Usage: ::merge('{example.Array}')
Example:
{stream.audioTags::merge('{stream.audioChannels}')}Input:
Atmos, TrueHD + 7.1Output:
Atmos, TrueHD, 7.1Combined usage
Example:
{stream.visualTags::merge('{stream.audioTags}')::merge('{stream.audioChannels}')::sort(asc)::slice(0, 4)::join(' - ')}Input:
HDR10, DV + Atmos, TrueHD + 7.1Output:
7.1 - Atmos - DV - HDR10Technical changes
Updated applySingleModifier: Added support for returning arrays, added
parseValueparameter to support context access for merging.Summary by CodeRabbit
Release Notes