Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: quote summary, quote clearance #1464

Merged
merged 4 commits into from
Dec 3, 2024
Merged

refactor: quote summary, quote clearance #1464

merged 4 commits into from
Dec 3, 2024

Conversation

asvishnyakov
Copy link
Collaborator

@asvishnyakov asvishnyakov commented Nov 19, 2024

Description

  • Introduced new temporary component QuoteSummary (which should be replaced with OrderSummary when it will be compatible)
  • No longer need manually call clearQuote on component effects if createSharedComposable is used. This has no direct effect on current quote pages, because we open all of them via window.location instead of router, but will prevent a bug in feat: AI document processing #1406 where useUserQuote is used for quote reloading without page reloading

Possible regression

  • Quote information should be correctly loaded when switch from one quote to another

References

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-2396

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.11.0-pr-1464-3e3f-3e3f7632.zip

@asvishnyakov asvishnyakov requested a review from a team as a code owner November 19, 2024 17:51
@asvishnyakov asvishnyakov changed the title refactor: quote totals, clearance refactor: quote summary, quote clearance Nov 19, 2024
NaMax66
NaMax66 previously approved these changes Nov 20, 2024
@asvishnyakov asvishnyakov dismissed stale reviews from ivan-kalachikov and NaMax66 via 3e3f763 December 3, 2024 12:17
Copy link

sonarqubecloud bot commented Dec 3, 2024

@NaMax66 NaMax66 merged commit b1f6486 into dev Dec 3, 2024
5 checks passed
@NaMax66 NaMax66 deleted the feat/refactor-quotes branch December 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants