feat: move images to assets directory #1506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaMax66
requested changes
Dec 18, 2024
client-app/shared/cart/components/add-bulk-items-to-cart-results-modal.vue
Outdated
Show resolved
Hide resolved
Andrew-Orlov
reviewed
Jan 9, 2025
ivan-kalachikov
previously approved these changes
Jan 9, 2025
|
Andrew-Orlov
requested changes
Jan 15, 2025
| import { SignInForm, useUser } from "@/shared/account"; | ||
| import { getImageUrl } from "@/ui-kit/utilities"; | ||
|
|
||
| const cfg = inject(configInjectionKey); |
There was a problem hiding this comment.
Use useThemeContext. All of theme context was already injected at app init. So you can remove computed afterwords and use app settings as it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2041
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.14.0-pr-1506-c42a-c42a682d.zip