feat: file section for configurable products #1619
Open
+842
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-kalachikov
requested review from
Andrew-Orlov,
goldenmaya,
NaMax66 and
IrinaSer
and removed request for
a team
NaMax66
reviewed
Mar 7, 2025
| } | ||
|
|
||
| watchEffect(async () => { | ||
| await fetchFileOptions(); |
There was a problem hiding this comment.
why async?
have you tried watchEffect(fetchFileOptions)?
There was a problem hiding this comment.
Just copy-pasted it from similar places. But you are right async is not needed here as well as a watchEffect, removed that. Simple void fetchFileOptions(); works fine here.
client-app/shared/catalog/components/configuration/product-configuration.vue
Show resolved
Hide resolved
client-app/shared/catalog/composables/useConfigurableProduct.ts
Outdated
Show resolved
Hide resolved
IrinaSer
previously approved these changes
Mar 12, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2796
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.18.0-pr-1619-a78e-a78e4695.zip