feat: implement ship-to-selector #1633
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldenmaya
requested review from
Andrew-Orlov,
ivan-kalachikov,
NaMax66 and
IrinaSer
and removed request for
a team
…remove it as unused, refactor
goldenmaya
commented
Mar 20, 2025
| <template> | ||
| <div class="ship-to-selector"> | ||
| <VcPopover | ||
| v-if="allAddresses.length > 0" |
There was a problem hiding this comment.
Move this condition to the parent tag, please
There was a problem hiding this comment.
there is v-else below, it needs to show add new button at once, when there are no added address yet
goldenmaya
commented
Mar 20, 2025
| <component :is="customSlots.default" /> | ||
| </div> | ||
| <div ref="headerElement" class="fixed z-40 w-full shadow-md print:hidden"> | ||
| <div class="relative z-[2] flex border-b bg-[--header-top-bg-color] px-5 py-2.5 text-xs max-sm:justify-center"> |
There was a problem hiding this comment.
We need some condition here to be added here OR add "empty:hidden" class.
There was a problem hiding this comment.
why do we need that? looks that there is always something will be rendered in ShipToSelector
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screencast.from.2025-03-20.11-49-42.mp4
References
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-2867
https://virtocommerce.atlassian.net/browse/VCST-2866
https://virtocommerce.atlassian.net/browse/VCST-2775
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.18.0-pr-1633-dca1-dca1df00.zip