Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New blade with prices for product #5

Merged
merged 8 commits into from
Sep 8, 2017
Merged

Conversation

megafreeman
Copy link
Contributor

No description provided.

@megafreeman
Copy link
Contributor Author

@asvishnyakov Alexander, could you make code review please

@asvishnyakov
Copy link
Contributor

asvishnyakov commented Sep 4, 2017

  1. User must not be able to add multiple prices with the same number of min. quantity
  2. You must check 'delete' permission on price deletion (look at api controller) and 'pricing:read' in item-prices.tpl.html
  3. (note sure, @tatarincev confirm please) api/products/{productId}/{catalogId}/pricesWidget → api/catalog/{catalogId}/products/{productId}/prices or api/pricing/{catalogId}/{productId}/prices
  4. Do not use inline styles

…able to add several prices with the same number of min. quantity in same pricelist.
@OlegoO OlegoO added this to the Operations milestone Sep 6, 2017
@megafreeman
Copy link
Contributor Author

1, 2 and 4 items from code review were implemented in last commits. 3rd item not applicable for this task i suppose

@megafreeman
Copy link
Contributor Author

I updated Pricing module on demo-vc to preview changes.
image

@Woland2k
Copy link
Contributor

Woland2k commented Sep 6, 2017

Done incorrectly, there shouldn't be a drop down for pricing. There should be "Add Price" button in the toolbar and no pricelist dropdown. Look at the description of 3 cases given in VirtoCommerce/vc-platform#1115

@megafreeman
Copy link
Contributor Author

megafreeman commented Sep 7, 2017

Another batch of the changes is available on the demovc-admin-dev for preview:

  1. fix validation data in grid
  2. display name of currency in price list selector
  3. empty (N/A) initial list price instead 0
  4. disable hiding editable columns List price and Min. quantity

image

@megafreeman megafreeman merged commit e0ffed4 into dev Sep 8, 2017
@megafreeman megafreeman deleted the dev-item-prices-1115 branch September 11, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants