Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP-4928: Update module docker development readme #2033

Merged
merged 9 commits into from
Sep 23, 2020

Conversation

mvktsk
Copy link
Contributor

@mvktsk mvktsk commented Sep 17, 2020

Some improvements to this guide:
https://virtocommerce.com/docs/latest/developer-guide/modules-development-via-docker/

  • Referenced to the create new module guide: https://virtocommerce.com/docs/latest/developer-guide/create-new-module/
  • Structured in a step by step manner, with details explanation.
  • Docker image naming for the platform changed to the latest
  • Added prerequisites for Authenticating to GitHub Packages
  • Added instructions on removing the environment.
  • Added instructions on what URL should be opened to launch platform.


```cmd
mklink /d <your_module_name> <full_path_to_your_module_project>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Symbolic links don't seem to work with Docker for windows (running as linux environment). Can you double check? Also for the docker, should we tell users to switch to linux containers?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Yes, symbolic links don't. Docs rewrite.
  2. Added command to docker-compose for auto-restart container

mvktsk and others added 4 commits September 18, 2020 12:16
Co-authored-by: Alexander Siniouguine <Woland2k@users.noreply.github.com>
Co-authored-by: Alexander Siniouguine <Woland2k@users.noreply.github.com>
@akak1977 akak1977 merged commit beb5356 into dev Sep 23, 2020
@akak1977 akak1977 deleted the docs/VP-4928-update-module-docker-development branch September 23, 2020 04:08
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants