Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Here's a building Vts.NetStandard library project. #1

Closed
wants to merge 3 commits into from
Closed

Here's a building Vts.NetStandard library project. #1

wants to merge 3 commits into from

Conversation

dcuccia
Copy link
Contributor

@dcuccia dcuccia commented Jun 11, 2017

  • Needs VS 2017 Preview 1 or later (see instructions here: https://www.microsoft.com/net/core#windowsvs2017)
  • Note that Silverlight is no longer supported in VS 2017, at least for now (boo, hiss)
  • Haven't dealt with specifying build actions/types for resource files
  • Updated the project to use the latest MathNet.Numerics (3.19.0)
  • Had to update two lines of code: 1) unused reference to Monte Carlo lib from IForwardSolver.cs, and 2) update Linear interp call in ReffCalculator.cs
  • Could be drop-in replacement for the new WPF library...worth a try, once the references are embedded correctly
  • Haven't figured out what happens when the NuGet dependencies used don't support the netstandard2.0 profile for non-desktop (.NET 4.7) runtimes, such as .NET Core on Windows/Mac/Linux/Xamarin.
  • Haven't used the API Port tool yet, which will shed light on the bullet above: https://github.com/Microsoft/dotnet-apiport

- Needs VS 2017 Preview 1 or later (see instructions here: https://www.microsoft.com/net/core#windowsvs2017)
- Note that Silverlight is no longer supported in VS 2017, at least for now (boo, hiss)
- Haven't dealt with specifying build actions/types for resource files
- Updated the project to use the latest MathNet.Numerics (3.19.0)
- Had to update two lines of code: 1) unused reference to Monte Carlo lib from IForwardSolver.cs, and 2) update Linear interp call in ReffCalculator.cs
- Could be drop-in replacement for the new WPF library...worth a try, once the references are embedded correctly
- Haven't figured out what happens when the NuGet dependencies used don't support the netstandard2.0 profile for non-desktop (.NET 4.7) runtimes, such as .NET Core on Windows/Mac/Linux/Xamarin.
- Haven't used the API Port tool yet, which will shed light on the bullet above: https://github.com/Microsoft/dotnet-apiport
@dcuccia
Copy link
Contributor Author

dcuccia commented Jun 12, 2017

Just a note - I pulled this on a new computer, and wasn't able to build the netstandard2.0 library. Error: "One or more packages are incompatible with .NETStandard,Version=v2.0."

This honestly is more what I was assuming would happen. Per the answer here, it has to be netstandard "all the way down":

https://stackoverflow.com/questions/37710474/one-or-more-packages-are-incompatible-with-netstandard-version-v1-5

The only obvious solution I see is to see if there are netstandard2.0 implementations of the NuGet dependencies in their alpha/beta channels, or to build them ourselves until they're available for netstandard2.0.

@dcuccia
Copy link
Contributor Author

dcuccia commented Jun 13, 2017

Looks like it my errors may have something to do with having VS 2017 15.2 installed, instead of VS 2017 15.3 Preview. Here's the link to 15.3: https://www.visualstudio.com/vs/preview/

@dcuccia
Copy link
Contributor Author

dcuccia commented Jun 13, 2017

...nope, same problems as before.

dcuccia added 2 commits June 27, 2017 19:02
…and MathNet Numerics NuGet packages; upgraded the desktop clients (MC CLI and CLI Test) to .NET 4.7 (.NET Standard 2.0 compatible). MC CLI is sompiling and running - seeing runtime exceptions for serialization.
@lmalenfant
Copy link
Member

We have converted the Silverlight Vts library and Test project to .NET Standard 2.0 and .NET Core and archived the Silverlight version due to it not being supported in Visual Studio 2017. This allowed us to keep all the source files in place with the Vts.Desktop project retaining the links. The .NET Standard version builds and all the unit tests pass. We have a few issues with the built in Visual Studio test runner but Resharper works great, as does "dotnet test" from the command line.
There is one library DotNetZip that doesn't have a .NET Standard version so it pulls in the 4.6.1 .NET framework version.

@dcuccia
Copy link
Contributor Author

dcuccia commented Apr 19, 2018 via email

@lmalenfant
Copy link
Member

It is "Vanilla" .NET Standard 2.0 but we haven't tried to run it on Linux or Mac other than with Mono. This will be the next step.

I haven't investigated DotNetZip but we actually don't use it anymore because it was used in the Silverlight application for saving files. The WPF application no longer zips the files. Thank you for the link to SharpZipLib, that might be worth checking out since it is .NET Standard already.

@dcuccia
Copy link
Contributor Author

dcuccia commented Apr 25, 2018 via email

@lmalenfant
Copy link
Member

We have converted our Silverlight library to .NET Standard 2.0, closing this pull request.

@lmalenfant lmalenfant closed this Sep 5, 2018
dcuccia added a commit that referenced this pull request Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants