Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible mistake in lifting docs #184

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Fix possible mistake in lifting docs #184

merged 1 commit into from
Sep 28, 2023

Conversation

kubukoz
Copy link
Contributor

@kubukoz kubukoz commented Sep 27, 2023 •
edited
Loading

I don't see url being used, so my hunch is that this is a leftover from the past that isn't being compile-time checked.

@lbialy lbialy merged commit 89f5fdd into VirtusLab:develop Sep 28, 2023
@kubukoz kubukoz deleted the patch-1 branch September 28, 2023 01:34
@pawelprazak pawelprazak added this to the beta milestone Sep 28, 2023
KacperFKorban pushed a commit that referenced this pull request Oct 4, 2023
@kubukoz @KacperFKorban
Update lifting.md (#184)
1d02480
@pawelprazak pawelprazak added area/docs The documentation and website impact/no-changelog-required This issue doesn't require a CHANGELOG update labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/docs The documentation and website impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
beta
Development

Successfully merging this pull request may close these issues.
3 participants
@kubukoz @pawelprazak @lbialy