Codegen - fix tests #281
Merged
Codegen - fix tests #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
added
area/codegen
pawelprazak
force-pushed
the
pprazak/codegen-fix-tests
branch
4 times, most recently
from
376237e to
1cece15
Compare
|
rebased on dependent PR |
pawelprazak
changed the base branch from
develop
to
pprazak/codegen-all-packages
|
I've changed the PR base for easier review |
pawelprazak
commented
Nov 7, 2023
pawelprazak
force-pushed
the
pprazak/codegen-fix-tests
branch
2 times, most recently
from
b562686 to
a4fc5f5
Compare
pawelprazak
force-pushed
the
pprazak/codegen-all-packages
branch
from
c24de3b to
30b5c7a
Compare
pawelprazak
force-pushed
the
pprazak/codegen-fix-tests
branch
2 times, most recently
from
237d599 to
d219534
Compare
pawelprazak
force-pushed
the
pprazak/codegen-fix-tests
branch
3 times, most recently
from
fcd6e1b to
12aa01e
Compare
- named types with provider now work - use AssetOrArchive in TypeMapper - fix union fallback type regression - eliminate redundant unions, e.g. String | String - fix missing key when package mapping present - fix type reference to a provider as resource - update codegen/Main - update various dependencies - Justfile - update compile-all, add test-all - use --server-false for provider packaging
pawelprazak
force-pushed
the
pprazak/codegen-fix-tests
branch
from
12aa01e to
3854a71
Compare
lbialy
approved these changes
Nov 10, 2023
|
thank you for the review! regarding bloop exit, we need more work on the mass-generation of the package anyway, so in a followup I'll try to further optimize this problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes on top of #280