Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs website #297

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Update docs website #297

merged 3 commits into from
Nov 15, 2023

Conversation

pawelprazak
Copy link
Contributor

A small website update inspired by #295

@pawelprazak pawelprazak added impact/usability Something that impacts users' ability to use the product easily and intuitively area/docs The documentation and website labels Nov 14, 2023
@pawelprazak pawelprazak requested a review from lbialy November 14, 2023 11:09
lbialy
lbialy requested changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@lbialy lbialy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd hold my horses with this and implement extension methods for Output[Resource] before, it's few lines of code but will require changes here.

@pawelprazak
Copy link
Contributor Author

I'd hold my horses with this and implement extension methods for Output[Resource] before, it's few lines of code but will require changes here.

On the other hand, we'll have to update the docs, after the release, in a lots of places anyway, so we can do it incrementally.

@pawelprazak pawelprazak added the blocked Something is blocking this issue form progressing label Nov 14, 2023
@pawelprazak
Copy link
Contributor Author

blocked on @lbialy

@pawelprazak pawelprazak added this to the 0.2.0 milestone Nov 15, 2023
@pawelprazak pawelprazak self-assigned this Nov 15, 2023
@lbialy
Copy link
Collaborator

lbialy commented Nov 15, 2023

ok I guess

@pawelprazak pawelprazak merged commit c9e6efc into develop Nov 15, 2023
@pawelprazak pawelprazak deleted the pprazak/docs-update branch November 15, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbialy lbialy lbialy approved these changes

Assignees

@pawelprazak pawelprazak

Labels
area/docs The documentation and website blocked Something is blocking this issue form progressing impact/usability Something that impacts users' ability to use the product easily and intuitively
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pawelprazak @lbialy