draft of get, read and refactor to readOrRegisterResource #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
approved these changes
Dec 5, 2023
pawelprazak
added
impact/broken
lbialy
force-pushed
the
read-and-get-resource
branch
from
bd3b265
to
17d2a5f
Compare
…ropagation and ValidatedResult
…y for Decoder[R <: Resource]
…source family via ReadResource call
pawelprazak
reviewed
Dec 13, 2023
|
|
||
| final case class CustomResourceOptions private[internal] ( | ||
| common: CommonResourceOptions, | ||
| provider: Option[ProviderResource], | ||
| deleteBeforeReplace: Boolean, | ||
| additionalSecretOutputs: List[String], | ||
| importId: Option[NonEmptyString] // TODO should this be Id? | ||
| importId: Option[ResourceId] // TODO should this be Id? |
There was a problem hiding this comment.
nit: the todo note appears to be fixed now :)
There was a problem hiding this comment.
Suggested change
| importId: Option[ResourceId] // TODO should this be Id? | |
| importId: Option[ResourceId] |
There was a problem hiding this comment.
it isn't really, resource options require a rewrite
pawelprazak
reviewed
Dec 13, 2023
| @@ -81,13 +95,13 @@ trait CustomResourceOptionsFactory: | |||
| customTimeouts: String | NotProvided = NotProvided, // CustomTimeouts // TODO | |||
| // resourceTransformations: List[ResourceTransformation], // TODO | |||
| // aliases: List[Output[Alias]], // TODO | |||
| urn: String | NotProvided = NotProvided, // TODO better type | |||
| urn: URN | NotProvided = NotProvided, // TODO better type | |||
There was a problem hiding this comment.
nit: the todo appear to be fixed now
There was a problem hiding this comment.
Suggested change
| urn: URN | NotProvided = NotProvided, // TODO better type | |
| urn: URN | NotProvided = NotProvided, |
pawelprazak
reviewed
Dec 13, 2023
| * | ||
| * If you want to understand this regex better head to: https://regex101.com/r/o2QWJ3/1 | ||
| * | ||
| * Now hear me out, this regex is a bit complicated, but it's not that bad. Let's break it down. We have to adhere to this grammar: |
There was a problem hiding this comment.
I like your humor, "not that bad regex" is dark, but still funny ;)
Don't worry, one day we'll write a proper parser :)
pawelprazak
reviewed
Dec 13, 2023
pawelprazak
reviewed
Dec 13, 2023
pawelprazak
reviewed
Dec 13, 2023
pawelprazak
reviewed
Dec 13, 2023
pawelprazak
reviewed
Dec 13, 2023
This was referenced Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.