Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors around Output.eval and Output#flatMap / ToFuture @implicitNotFound #443

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Improve errors around Output.eval and Output#flatMap / ToFuture @implicitNotFound #443

merged 1 commit into from
Apr 9, 2024

Conversation

lbialy
Copy link
Collaborator

@lbialy lbialy commented Apr 8, 2024

Adds nice compile error for wrong usage of flatMap and for missing instance of Result.ToFuture

@lbialy lbialy added kind/improvement An improvement with existing workaround impact/usability Something that impacts users' ability to use the product easily and intuitively impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation size/S Estimated effort to complete (1-2 days). area/api User visible API labels Apr 8, 2024
@lbialy lbialy added this to the 0.3.0 milestone Apr 8, 2024
@lbialy lbialy requested a review from pawelprazak April 8, 2024 20:19
@pawelprazak pawelprazak changed the title Improve errors around Output.eval and Output#flatMap / ToFuture @implicitNotFound Improve errors around Output.eval and Output#flatMap / ToFuture @implicitNotFound Apr 9, 2024
pawelprazak
pawelprazak approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@pawelprazak pawelprazak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@lbialy lbialy mentioned this pull request Apr 9, 2024
Merged
@lbialy lbialy force-pushed the lbialy/issue-434 branch from 4e60cb3 to 6c3d93f Compare April 9, 2024 12:46
@lbialy lbialy merged commit c5ef4ca into main Apr 9, 2024
2 checks passed
@lbialy lbialy deleted the lbialy/issue-434 branch April 9, 2024 13:28
@lbialy lbialy mentioned this pull request Apr 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelprazak pawelprazak pawelprazak approved these changes

Assignees
No one assigned
Labels
area/api User visible API impact/first-48 This bug is likely to be hit during a user's first 48 hours of product evaluation impact/usability Something that impacts users' ability to use the product easily and intuitively kind/improvement An improvement with existing workaround size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbialy @pawelprazak