Fix issue 489 - trace level messages get evaluated to send to Pulumi engine #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelprazak
added
kind/bug
|
Changed it so that no trace level messages get sent to pulumi engine. Temporary solution.
|
|
Found a solution that actually works. No need for half-assed temporary solutions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fansi has some issues with some ansi escape codes as reported in #489. This does not fix the inner issue, we just stop sending trace log events to the engine and that prevents evaluation of the lines that cause the problem. Alternative would be to stop using pprint/fansi combo for debug but that would make debugging experience much worse so no go.
Therefore this is fixed for the end user, weird fansi (?) bug persists on trace level and can / will come back to bite us in debugging.