Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unit test for GitMacheteErrorReportSubmitter #973

Closed
PawelLipski opened this issue Jul 5, 2022 · 0 comments · Fixed by #1048 or #1055
Closed

Add a unit test for GitMacheteErrorReportSubmitter #973

PawelLipski opened this issue Jul 5, 2022 · 0 comments · Fixed by #1048 or #1055
Assignees
@MaciejG604
Labels
good first issue Good for newcomers testing Relates to tests and testability
Milestone
v2.2.0

Comments

@PawelLipski
Copy link
Collaborator

To prevent uncaptured errors like #972.

Probably just a test for constructNewGitHubIssueUri will be enough (as submit is pretty unwieldy to test).
@PawelLipski PawelLipski added good first issue Good for newcomers testing Relates to tests and testability labels Jul 5, 2022
@PawelLipski PawelLipski added this to the v2.2.0 milestone Aug 9, 2022
@PawelLipski PawelLipski mentioned this issue Aug 10, 2022
Closed
@MaciejG604 MaciejG604 linked a pull request Aug 10, 2022 that will close this issue
Add test for GitMacheteErrorReportSubmitter #1048
Merged
@PawelLipski PawelLipski linked a pull request Aug 12, 2022 that will close this issue
Massage GitMacheteErrorReportSubmitter and its tests a bit more #1055
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaciejG604 MaciejG604

Labels
good first issue Good for newcomers testing Relates to tests and testability
Projects
None yet
Milestone
v2.2.0
2 participants
@PawelLipski @MaciejG604