Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request URL is too long from Report and Clear All error #1008

Closed
mkondratek opened this issue Jul 28, 2022 · 7 comments · Fixed by #1096, #1100 or #1439
Closed

Request URL is too long from Report and Clear All error #1008

mkondratek opened this issue Jul 28, 2022 · 7 comments · Fixed by #1096, #1100 or #1439
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mkondratek
Copy link
Collaborator

I got an internal ide error from our plugin that generated too long url.

We should consider possibilities of trimming the URL (issue content) or using a different REST request if possible.

@PawelLipski
Copy link
Collaborator

Whoops 9KB of URL ;D

@PawelLipski PawelLipski added the bug Something isn't working label Jul 28, 2022
@PawelLipski
Copy link
Collaborator

Actually... this is closely related to @MaciejG604's current #973, lemme also assign to Maciej

@PawelLipski PawelLipski added this to the v2.2.0 milestone Aug 10, 2022
@PawelLipski
Copy link
Collaborator

And I think we could actually cut off the release after this one (probably as v2.1.1 tho)

@MaciejG604
Copy link
Contributor

Most of the URL's contents is the stack trace of the exception thrown by the plugin, we could consider trimming that.

@PawelLipski
Copy link
Collaborator

PawelLipski commented Aug 10, 2022

Yeah, let's check if some obviously redundant pieces like:

are present in the contents; they can be stripped with no loss of vital information. If it comes to other parts — TBD what can be stripped (sometimes it's the root cause exceptions that matters more, sometimes the top-level exception)

@PawelLipski
Copy link
Collaborator

AFAIK from the original URL... it's a matter of triple-wrapped exception from JGit, which adds up to a loooot of stack frames :/

I'd suggest e.g. leaving only the first frame (i.e. the place where exception has been instantiated) in all exceptions, except for the root cause, where full stack trace should be included.

In particular, where exception has no cause, then it's considered a root cause itself for this purpose

@PawelLipski
Copy link
Collaborator

PawelLipski commented Jan 11, 2023

Still the same, I've got such a loooong URL (14 kB)

@PawelLipski PawelLipski reopened this Jan 11, 2023
@PawelLipski PawelLipski modified the milestones: v3.0.0, v3.3.1 Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment