Fix Bad Request on Open GitHub Issue report when URL is too long #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar problem: VirtusLab/git-machete-intellij-plugin#1008 (thx @mkondratek ) |
exigow
changed the title
|
Looks like max length for GH URL is 2^13 (8192). |
exigow
force-pushed
the
exigow/trim-github-errors
branch
from
06094e1
to
504d718
Compare
|
|
exigow
force-pushed
the
exigow/trim-github-errors
branch
from
504d718
to
5e32303
Compare
exigow
changed the title
Also: I've added few improvements.
Test plan
1. Add error("test") to CodyToolWindowContent constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: If the URL is too long (mainly because of stacktrace), GitHub blocks the
issues/newendpoint. User is facing Bad Request.Also: I've added few improvements.
Test plan
Demo