Try to fix CI tests #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philwalk
added a commit
to philwalk/scala-cli
that referenced
this pull request
Jul 24, 2025
Gedochao
added a commit
that referenced
this pull request
Jul 31, 2025
* fix for 3789 - script if .sc, or (if no extension) has shebang * verify-non-directory in shebang-test * reorder isDir case ahead of isShebangScript * added integration test for enabled case * restore line endings * adjust new test * quote msg * fix quoted msg * Apply suggestions from code review suggested changes Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com> * remove isScript extra paren * add script.sources property * fix failing CI / Checks test due to import order * revert treating .scala files as Script * revert attempt #2 * revert /Inputs.scala changes * Apply suggestions from code review Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com> * legal script extension restricted to .sc or empty string * remove unrelated code * cleanup imports * corrected hasShebang check * corrected hasShebang test * hasShebang adapted for /dev/fd * input sc script def * fix tests * avoid hasShebang test of streamed bytes * disable hasShebang test for streams * Update modules/integration/src/test/scala/scala/cli/integration/RunScriptTestDefinitions.scala Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com> --------- Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com> Co-authored-by: Phil <philwalk@gmail.com>
Gedochao
added a commit
that referenced
this pull request
Aug 4, 2025
* fix for 3789 - script if .sc, or (if no extension) has shebang * verify-non-directory in shebang-test * reorder isDir case ahead of isShebangScript * added integration test for enabled case * restore line endings * adjust new test * quote msg * fix quoted msg * Apply suggestions from code review suggested changes Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com> * remove isScript extra paren * add script.sources property * fix failing CI / Checks test due to import order * revert treating .scala files as Script * revert attempt #2 * revert /Inputs.scala changes * Apply suggestions from code review Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com> * add docs test to scala-script.md * remove brackets from regex * rename new test as show-sources.md * check fix * sclicheck tests for .sc, .scala, and .java sources * fine-tuned show-sources.md * additional examples in show-sources.md --------- Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com> Co-authored-by: Phil <philwalk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.