Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Scala 3 LTS to 3.3.5 #3466

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Update Scala 3 LTS to 3.3.5 #3466

merged 2 commits into from
Jan 29, 2025

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao requested a review from tgodzik January 29, 2025 09:14
@Gedochao
Copy link
Contributor Author

Added a band-aid solution for downgrading LTS to 3.3.4 when used with the default version of Ammonite.
The downgrading logic doesn't fully work as expected, as per #3467.
We may soon stop having to rely on Ammonite for our REPL tests as well, when scala/scala3#21242 gets delivered (likely in Scala 3.7.x), so I'm not sure if this is worth more effort at this point.

Should be ready for re-review.

@Gedochao Gedochao requested a review from tgodzik January 29, 2025 13:59
@Gedochao Gedochao enabled auto-merge (squash) January 29, 2025 15:24
@Gedochao Gedochao merged commit e51e17a into VirtusLab:main Jan 29, 2025
50 checks passed
@Gedochao Gedochao deleted the update/scala-3.3.5 branch February 10, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gedochao @tgodzik