Don't use any custom logic when publishing to Sonatype Central #3759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
commented
Jun 24, 2025
| - name: GPG setup | ||
| run: .github/scripts/gpg-setup.sh | ||
| env: | ||
| PGP_SECRET: ${{ secrets.PGP_SECRET }} |
Contributor
Author
There was a problem hiding this comment.
I get the feeling that running gpg-setup.sh is no longer necessary with this approach... 🤔 Not entirely sure, however. Likely no harm to leave it for now?
Gedochao
commented
Jun 24, 2025
Comment on lines
+1680
to
+1683
| MILL_PGP_SECRET_BASE64: ${{ secrets.PGP_SECRET }} | ||
| MILL_PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }} | ||
| MILL_SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
| MILL_SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} |
Contributor
Author
There was a problem hiding this comment.
tgodzik
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to:
As suggested in https://discord.com/channels/632150470000902164/940067748103487558/1386716191443255397