feat: add --watch-clear-screen option to clear terminal on rebuild#4031
feat: add --watch-clear-screen option to clear terminal on rebuild#4031krrish175-byte wants to merge 5 commits intoVirtusLab:mainfrom
Conversation
modules/cli/src/main/scala/scala/cli/commands/compile/Compile.scala
Outdated
Show resolved
Hide resolved
Gedochao
left a comment
There was a problem hiding this comment.
Thanks for contributing! I left some comments.
As noted above, we need tests for this.
Also, make sure to regenerate reference docs, since you're adding a new command line option. Refer to https://github.com/VirtusLab/scala-cli/blob/main/CONTRIBUTING.md#rules-for-a-well-formed-pr
modules/cli/src/main/scala/scala/cli/commands/package0/Package.scala
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
| else if (options.sharedRepl.watch.watchMode) { | ||
| var isFirstRun = true |
There was a problem hiding this comment.
| var isFirstRun = true | |
| val isFirstRun = new AtomicBoolean(true) |
modules/cli/src/main/scala/scala/cli/commands/shared/SharedWatchOptions.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/shared/SharedWatchOptions.scala
Outdated
Show resolved
Hide resolved
|
@Gedochao |
|
@krrish175-byte I'll try to take a look and review in the next couple of days, but I can already see it's failing formatting (need to run |
c461b0d to
f8e80db
Compare
|
Currently:
|
Closing issue
closes #4029