Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed install with pip, added new homebrew path #248

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

lo-chr
Copy link
Contributor

@lo-chr lo-chr commented Dec 27, 2023

This PR changes the setup.py and adds new paths to the configuration of the library and include folders for handling the pip installation on Macs with Apple Silicon.

On Apple Silicon, Homebrew uses another path (/opt/homebrew instead of /usr/local) in comparison to the Intel Mac Version (see https://docs.brew.sh/Installation).

Without this change the build would fail on this platform, like described in #239.

I verified the change manually using pip install -e yara-python on the (locally changed) packaged version, downloaded from the PyPi repository.

Copy link

google-cla bot commented Dec 27, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@plusvic plusvic merged commit 01493ef into VirusTotal:master Dec 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants